search

evanphx / benchmark-ips

Provides iteration per second benchmarking for Ruby
MIT License
1.72k stars 97 forks source link

Gemspec is missing #23

Closed kirs closed 9 years ago

kirs commented 9 years ago

Due the missing gemspec, the gem can't be used with Bundler as a git repo:

gem 'benchmark-ips', github: 'evanphx/benchmark-ips', commit: 'abc'

@evanphx do you mind if I send a PR fixing it?

evanphx commented 9 years ago

There is really no reason to use benchmark-ips from git directly. Why not use the gem?

kirs commented 9 years ago

Actually there is. I make a fix (https://github.com/kirs/benchmark-ips/compare/quiet-mode) and was going to use it directly from the branch on GIthub.

evanphx commented 9 years ago

Ah! That's make mistake, I should release that.

evanphx commented 9 years ago

Er, that's on your repo. Well, you can always make a gemspec in your fork. :smile_cat:

kirs commented 9 years ago

Thanks a lot! Do you think I can send a PR with :quiet option?

On 12 January 2015 at 18:38, Evan Phoenix notifications@github.com wrote:

Closed #23 https://github.com/evanphx/benchmark-ips/issues/23 via f07760e https://github.com/evanphx/benchmark-ips/commit/f07760e653ddda199705b16c6789dc30f26e6cc1 .

Reply to this email directly or view it on GitHub https://github.com/evanphx/benchmark-ips/issues/23#event-217533003.

evanphx commented 9 years ago

Sure! Send away!

On Tue, Jan 13, 2015 at 3:28 AM, Kir Shatrov notifications@github.com wrote:

Thanks a lot! Do you think I can send a PR with :quiet option? On 12 January 2015 at 18:38, Evan Phoenix notifications@github.com wrote:

Closed #23 https://github.com/evanphx/benchmark-ips/issues/23 via f07760e https://github.com/evanphx/benchmark-ips/commit/f07760e653ddda199705b16c6789dc30f26e6cc1 .

Reply to this email directly or view it on GitHub https://github.com/evanphx/benchmark-ips/issues/23#event-217533003.

Reply to this email directly or view it on GitHub: https://github.com/evanphx/benchmark-ips/issues/23#issuecomment-69731017