search

evanphx / benchmark-ips

Provides iteration per second benchmarking for Ruby
MIT License
1.72k stars 97 forks source link

use runtime if ips is not available #45

Closed kbrock closed 9 years ago

kbrock commented 9 years ago

I think iter means that ips is not available, and runtime should be used instead.

I'd like to write specs around this and wanted to make sure I understood the purpose of iter

Benchmark::Compare#compare is called with @entries by IPS. It looks like @entries comes from add_entry, which populates ips but not runtime.

  1. Are you thinking about having compare support entries with either ips, ips_sd OR runtime?

  2. Seems the gem is focused on a) determining the iteration values, b) timing, c) comparing, and d) reporting - but in theory any of those could be swapped out. E.g.: the timing could be from ruby-prof or even an explain plan from psql.

    Is this close to your thought path / of interest?

  3. I was also thinking about moving more towards printf in this method with %20s rather than the puts and printf mix. Thoughts?
kbrock commented 9 years ago

Come to think of it, it seems like there are a number of similar interfaces here.

the json and comparison interfaces just take data, though in 2 different formats. summary too for that matter. the suites and $stdout (called from run / warmup) have similar interfaces as well. not sure if you are curious about making all 5 of these similar.

It seems consolidation of this interface may be beneficial, but keeping them separate works for me too. If you think it may work, just say so and I can throw something together

evanphx commented 9 years ago

Quite right, that's a typo.