search

evanphx / benchmark-ips

Provides iteration per second benchmarking for Ruby
MIT License
1.72k stars 97 forks source link

Fix runtime comparison #48

Closed bquorning closed 9 years ago

bquorning commented 9 years ago

I kept getting an

undefined method `rjust' for
#<Benchmark::IPS::Report::Entry:0x007ff53b8a2950> (NoMethodError)

Makes me wonder if this code is even used by anyone?

bquorning commented 9 years ago

Any comment on whether this code is even reachable? I imagine someone would have reported a bug earlier if it were.

evanphx commented 9 years ago

Ok, tracking it all the way back, it looks like that code path is just rarely if ever used. It provides the ability to compare reports that don't do ips, but no one uses it for anything else. We could probably just remove that other code path at this point.

bquorning commented 9 years ago

I may open a PR for removing that code path, then :-)