move fails with "missing value" if from is ""

[lucastheisen]

According to the JSON Pointer RFC 6901:

The following JSON strings evaluate to the accompanying values:

""           // the whole document

But using that as a from results in a missing value error.

Adding this test will demonstrate the bug:

func TestMoveFromRoot(t *testing.T) {
    expected := `{"baz":{"foo":"bar"}}`
    res, err := applyPatch(`{"foo":"bar"}`, `[{"op":"move","from":"","path":"/baz"}]`)
    if err != nil {
        t.Errorf("unexpected error: %+v", err)
    } else if res != expected {
        t.Errorf("expected:\n%s\ngot:\n%s", expected, res)
    }
}

[lucastheisen]

Well, i just saw this in the RFC for JSON Patch:

The "from" location MUST NOT be a proper prefix of the "path" location; i.e., a location cannot be moved into one of its children.

So my use case is invalid (as is the test per-se)... But the lack of support for "" JSON Pointer may still be something you want to address. You can close this issue out if you would like, or modify it to deal with the JSON Pointer support.

[evanphx]

@lucastheisen Gotcha gotcha. Trying some other json patch implementations, they largely fail to handle when from is "", so I think we're in a bit of uncharted waters here.

[evanphx]

Could you have a look at #193 and give me your thoughts? Thanks!

[lucastheisen]

@evanphx , that merge looks great.