evanplaice / node-ftpsync

Intelligent file syncronization over FTP
http://evanplaice.github.io/node-ftpsync
MIT License
74 stars 21 forks source link

Error on removing files with accent (like é) during sync operation on ftp #9

Closed jmzoda closed 8 years ago

jmzoda commented 9 years ago

Didn't check with accents on directories but discovered errors on removing files with accent (like é) during sync operation on ftp. Copying without any troubles but removing files with accent on ftp gives : 550 File not found error.

See extract of ftpsync + ftp server logs below for more details : '' 'Consolidating' '-------------------------------------------------------------' 'Mkdir:' [] '' 'Rmdir:' [] '' 'Add:' [ '/HOME-abonnés.jpg' ] '' 'Updates:' [] '' 'Remove:' [ '/HOME-abonnés.jpg' ] ''

Consolidation complete. '' 'Committing' '-------------------------------------------------------------' '-' Additions complete. Remove failed. Removals failed. Commit failed. Commit complete. Removals complete '-' Warning: 550 File not found Use --force to continue. Aborted due to warnings.

Ftp shows :

230 Logged on type I 200 Type set to I pasv 227 Entering Passive Mode (...) stor /HOME-abonnés.jpg 150 Opening data channel for file upload to server of "/HOME-abonnés.jpg" 226 Successfully transferred "/HOME-abonnés.jpg" dele /HOME-abonnés.jpg 550 File not found disconnected.

Thanks in advance

jmzoda commented 9 years ago

Error comes from file parser.js in https://github.com/sergi/parse-listing used by jsftp.js in ftpsync.js and of course this project.

evanplaice commented 9 years ago

Currently waiting for a response. If it has been fixed I'll update the dependencies to the latest.

jmzoda commented 9 years ago

Not currently fixed. It is has not been updated on the master branch of jsftp. Unfortunately my issue is still open : https://github.com/sergi/jsftp/issues/121

evanplaice commented 9 years ago

@jmzoda Thanks for the update.

jmzoda commented 9 years ago

@evanplaice Don't hesitate. You are welcome.

evanplaice commented 8 years ago

@jmzoda I just finished updating all the dependencies. JSFTP is has been bumped to the latest including the commit that fixed this issue.

I'm going to close for now, let me know if you run into any more issues.