search

evanpurkhiser / keyfinder-cli

A CLI wrapper for libkeyfinder. Making DJs lives easier.
GNU General Public License v3.0
111 stars 23 forks source link

README.md: update link for libkeyfinder to Mixxx fork #17

Closed Be-ing closed 3 years ago

evanpurkhiser commented 3 years ago

Oh I had no idea there was a fork. I'll have to look closer at this since I maintain some libkeyfinder packages.

evanpurkhiser commented 3 years ago

I would like to keep the original attribution though, so maybe we can also make it clear that this one's the fork

Be-ing commented 3 years ago

The attribution is kept prominently in the fork's README.md and it still appears as a fork of the original repo on GitHub.

evanpurkhiser commented 3 years ago

Cool, sounds good. Thanks for this!

Be-ing commented 3 years ago

No problem. Some keyfinder-cli users contributed some nice improvements to the documentation for building libkeyfinder on macOS. I have packaged it for vcpkg which we are using for Mixxx builds now.

By the way, this fork happened with @ibsh's approval. He gave me write access to the original repo and I decided to fork it to the mixxxdj organization.

evanpurkhiser commented 3 years ago

Oh! That's great to know, I'll have to look into this more! I also maintain https://github.com/EvanPurkhiser/keyfinder-py which is pretty much just this code

I also maintain a personal homebrew recipie for libkeyfinder https://github.com/EvanPurkhiser/homebrew-personal/blob/master/libkeyfinder.rb which I'll have to update, and maybe finally try to get merged into the master homebrew list