search

evanshortiss / html5-fs

Node.js style wrapper for the HTML5/Cordova FileSystem API
16 stars 7 forks source link

readdir should return an array of strings #3

Open dominictarr opened 8 years ago

dominictarr commented 8 years ago

looking around here I've noticed that readdir returns a list of File objects. That isn't compatible with node's fs. it should return a list of strings.

https://nodejs.org/dist/latest-v6.x/docs/api/fs.html#fs_fs_readdir_path_options_callback

dominictarr commented 8 years ago

would you merge a pull request to make this change?

evanshortiss commented 8 years ago

@dominictarr would be happy to do so if you have something in the works 👍

dominictarr commented 8 years ago

as it turned out, I don't need this module for that project anymore. but it the need might come back, so i'll make one if it does.

evanshortiss commented 8 years ago

Good stuff, I'll leave this open for now since it'll need to be patched.

This project needs a little modernisation and cleaning up besides this too!