search

evanshortiss / lintspaces-cli

A CLI for the node-lintspaces module.
MIT License
18 stars 6 forks source link

verbose option #12

Closed gemal closed 8 years ago

gemal commented 8 years ago

could be nice with a verbose option that printed out:

- checking file /var/tmp/xxx.js
- checking file /var/tmp/xxx2.js
evanshortiss commented 8 years ago

@gemal agreed, this could be useful. So you would like output like this?

~/workspaces/express-expeditious$ lintspaces -s 4 -d "tabs" lib/cache-key.js 

Checking: /workspaces/express-expeditious/lib/cache-key.js

File: /workspaces/express-expeditious/lib/cache-key.js
Line: 5 Unexpected spaces found. [warning]
Line: 6 Unexpected spaces found. [warning]
Line: 7 Unexpected spaces found. [warning]
Line: 8 Unexpected spaces found. [warning]
Line: 9 Unexpected spaces found. [warning]
Line: 10 Unexpected spaces found. [warning]
Line: 11 Unexpected spaces found. [warning]
Line: 12 Unexpected spaces found. [warning]
Line: 13 Unexpected spaces found. [warning]
Line: 14 Unexpected spaces found. [warning]
Line: 15 Unexpected spaces found. [warning]
Line: 16 Unexpected spaces found. [warning]

I'd be happy to accept a PR for this if you have something in the works. If not I can try get around to it sometime 👍

gemal commented 8 years ago

tried to add a pull request Also fixing some inconsistency in the "." of the sentences

evanshortiss commented 8 years ago

Sounds good @gemal, I'll keep an eye out and review it once you have opened the PR. Appreciate it!

gemal commented 8 years ago

the pull requests is there

evanshortiss commented 8 years ago

@gemal I can't see it here: https://github.com/evanshortiss/lintspaces-cli/pulls

Could you open it again?

gemal commented 8 years ago

should be there now. Not a github expert :)

gemal commented 8 years ago

pull is there with a fix to the readme too

gemal commented 8 years ago

@evanshortiss can you review and merge?

evanshortiss commented 8 years ago

@gemal added comments to the PR, very quick fixes 😄