search

evanshultz / neater-bookmarks

A neater bookmarks tree popup extension for Chrome
https://chrome.google.com/webstore/detail/ofgjggbjanlhbgaemjbkiegeebmccifi
MIT License
215 stars 61 forks source link

Mac: Window auto resizes from Max to smaller size #26

Open srokos opened 10 years ago

srokos commented 10 years ago

awesome work on this, one of my must have extensions for Chrome!

On to what appears to be a bug for me: When opening the bookmark window, it opens at max size then autoresizes down to something around 300px or so. This is odd because the tree size is very large so it should not be resizing down at all. If I open a folder it figures this out and resizes the window to the max size.

evanshultz commented 10 years ago

Can you please attach a video so I can see this? Please include launching the popup both with a vertically tall and a vertically short tree.

Wunderkemmer commented 10 years ago

I'm also seeing this issue on Chrome under OS X. It happens more frequently when repeatedly clicking the button to display the popup.

evanshultz commented 10 years ago

Can you please send a video as requested above? I want to make sure I clearly understand.

Wunderkemmer commented 10 years ago

Let me see if I can grab one for you... unfortunately I've already installed a hacked version of the extension that overrides the resizing behavior to always show the popup with a height of 530 pixels. :) Since the resizing code is in a timeout, my guess is that there's some sort of race condition setting the wrong size at the wrong time when there are rapid user interactions.

Until the video, here's a more detailed description.

The first time I click to show the bookmark popup, it usually immediately starts at the maximum size, but occasionally it appears at the minimum size then rapidly scales up to the maximum. So far so good. But if I click on the button again without closing the popup, it has a chance of popping up at maximum size then rapidly scaling down to the minimum and staying there, or popping up at the minimum size immediately and staying there. And as srokos described, toggling the state of any folder resizes the popup to the correct size.

The end results are frequent undersized popups that either require lots of scrolling or a folder toggle to force them to the correct size.

JoshHelfferich commented 10 years ago

I'm seeing this issue too, so I made a quick video. Hope this helps!

https://dl.dropboxusercontent.com/u/434310/neaterbookmarks.mov