search

evanshultz / neater-bookmarks

A neater bookmarks tree popup extension for Chrome
https://chrome.google.com/webstore/detail/ofgjggbjanlhbgaemjbkiegeebmccifi
MIT License
215 stars 61 forks source link

add 'esc' close overlay. #34

Open GongLe opened 10 years ago

GongLe commented 10 years ago

Maybe add 'esc' close overlay will be better

evanshultz commented 10 years ago

Can you describe the use case for this? Clicking outside the popup area, or on the extension icon, will close the popup. Please help me understand why you want a keyboard shortcut for the popup.

zachofalltrades commented 10 years ago

The 'esc' key is an almost universal shortcut for backing out of whatever popup the user interface has currently brought to the top layer.

I just played around a bit and realized that the 'esc' key DOES close the popup if you are using the keyboard to navigate through the bookmarks, but it does NOT close the popup when the cursor is in the search box. So detecting the escape key while in the search box is the only deficiency in this regard.

DLight1 commented 9 years ago

A workaround to this problem is to press Tab before Esc, but I agree that this problem should be fixed. It's a bit annoying.

doggan commented 9 years ago

:+1:

As mentioned, navigating through the bookmarks (with tab or up/down arrows) and then pressing ESC works. Would be nice to close the window without any bookmarks selected though. Current behavior feels almost like a bug.