search

evant / gradle-retrolambda

A gradle plugin for getting java lambda support in java 6, 7 and android
Apache License 2.0
5.3k stars 449 forks source link

Proguard still fails with retrolambda 2.5.1 targeting Java 7 #251

Closed Perseverance1139 closed 7 years ago

Perseverance1139 commented 7 years ago

Proguard reports error for each lambda usage: can't find referenced class java.lang.invoke.MethodHandles$Lookup can't find referenced class java.lang.invoke.MethodHandles

Looking at this line here, I wonder should we remove methodhandles for Java 7 as well? https://github.com/orfjackal/retrolambda/blob/6d5a4c1fd9d094452cfde2096a81ab82a0c1c9ce/retrolambda/src/main/java/net/orfjackal/retrolambda/Transformers.java#L116

Thanks!

evant commented 7 years ago

A couple of things: The README suggests adding -dontwarn java.lang.invoke.* to your proguard config, shouldn't this suppress that error? Secondly, if you think this change should be made, could you file it against https://github.com/orfjackal/retrolambda instead of this project?

Perseverance1139 commented 7 years ago

Sorry about filing to the wrong project. My apologies...