evant / gradle-retrolambda

A gradle plugin for getting java lambda support in java 6, 7 and android
Apache License 2.0
5.3k stars 449 forks source link

include/exclude configuration doesn't apply #261

Open spleenjack opened 6 years ago

spleenjack commented 6 years ago

retrolambda plugin 3.7 ignores the include/exclude configuration setting right now and transforms the whole project's code.

Some context: the new gradle plugin 3.x with desugaring cannot desugar the library projects actually, here is an issue about that: https://issuetracker.google.com/issues/67452341

So, we would like to build two different flavors in the future, the first flavor with retrolambda and with disabled desugaring, and the second flavor without retrolambda and with enabled desugaring. We asked to add the feature to enable/disable desaguring per flavor, since now this is possible only per project manner.

But this is useless if we can't use the feature to include/exclude retrolambda for specified variants.

Can you fix this?

evant commented 6 years ago

I think it stopped working after switching to the transform api. I was actually considering taking the feature out since it seemed nobody was using it. Shouldn't be too hard to fix, the transform needs to check if the variant is disabled and just copy all the files over instead of running retrolambda.

mmitic-lotusflare commented 6 years ago

@evant Any updates on this?