evanw / esbuild

An extremely fast bundler for the web
https://esbuild.github.io/
MIT License
37.59k stars 1.11k forks source link

`$configDir` may not be working correctly #3812

Closed ICJR closed 6 days ago

ICJR commented 1 week ago

I believe esbuild-loader is not working correctly with $configDir.

Based on https://github.com/evanw/esbuild/issues/3782 I believe you applied $configDir for paths configuration only, I believe it applies to any path defined within tsconfig ( including exclude and include ).

evanw commented 1 week ago

I believe esbuild-loader is not working correctly with $configDir.

This may be a bug with esbuild-loader instead of with esbuild. Please provide a way to reproduce the issue here that uses esbuild (not esbuild-loader). Note that this is the esbuild repo and esbuild-loader is a separate project (which you can find here). This repo has nothing to do with Webpack.

Based on #3782 I believe you applied $configDir for paths configuration only, I believe it applies to any path defined within tsconfig ( including exclude and include ).

The exclude and include fields are not used by esbuild's bundler: https://esbuild.github.io/content-types/#tsconfig-json. So it would be meaningless for esbuild to apply $configDir to them as it wouldn't have any effect on anything that esbuild does.

ICJR commented 6 days ago

Gotcha, I assumed it had something to do with the bundling package. Thank you.