evanw / glfx.js

An image effects library for JavaScript using WebGL
https://evanw.github.io/glfx.js/
MIT License
3.26k stars 402 forks source link

remove `checkFramebufferStatus` call in `texture.js` `drawTo` #59

Open Axel-Jacobsen opened 2 years ago

Axel-Jacobsen commented 2 years ago

Howdy!

The function call of checkFramebufferStatus in texture.js takes about 37% of drawTo calls on Chrome, by my profiling:

with_checkFrameBufferStatus.json.zip

On analysis, when checkFramebufferStatus returns with something other than FRAMEBUFFER_COMPLETE, an error is thrown.

If an error is not manually thrown, an error would still pop-up no? If the if-statement is removed, the only thing lost is a bit of clarity (occasionally, I haven't ever bumped into this issue) for a 40% gain of efficiency.

Simply removing this if-statement speeds things up:

without_getFramebufferStatus.json.zip

Perhaps I am missing something that checkFramebufferStatus does, and if this is the case please let me know!

Cheers, I adore glfx.js!