search

evanw / node-source-map-support

Adds source map support to node.js (for stack traces)
MIT License
2.16k stars 222 forks source link

add info about node 12.12.0 `--enable-source-maps` #322

Closed DetachHead closed 1 year ago

DetachHead commented 1 year ago

fixes #321

KotlinIsland commented 1 year ago

LGTM!

sheremet-va commented 1 year ago

I just want to point out that --enable-source-maps doesn't work with vm.runInThisContext (and I assume other ways of running script with vm). So tools like Jest and Vite still need to use the package.

LinusU commented 1 year ago

I just want to point out that --enable-source-maps doesn't work with vm.runInThisContext (and I assume other ways of running script with vm). So tools like Jest and Vite still need to use the package.

@DetachHead could you add a note about this as well please? 🙏

DetachHead commented 1 year ago

@sheremet-va @LinusU in my experience source maps have worked in both jest and vite without needing to use this package

sheremet-va commented 1 year ago

This is because jest already includes it. I meant that this package is required for lib developers, not necessarily users.

DetachHead commented 1 year ago

i feel like this information is a bit too low level for most users. i think the vast majority of people who stumble upon this package aren't developers of jest or vite, and wouldn't have a clue what vm and vm.runInThisContext is.

i will include it if you guys think it's necessary, however i think installation instructions should be as simple as possible

DetachHead commented 1 year ago

how's that?

LinusU commented 1 year ago

i feel like this information is a bit too low level for most users. i think the vast majority of people who stumble upon this package aren't developers of jest or vite, and wouldn't have a clue what vm and vm.runInThisContext is.

i will include it if you guys think it's necessary, however i think installation instructions should be as simple as possible

Sorry, merged before I read this. Yeah, might have been unnecessary but I think with the parenthesis it turned out nice 👍