search

evanw / packer

Simple port of /packer/ by Dean Edwards to node.js
86 stars 37 forks source link

unmatching outcome #6

Open fedeghe opened 8 years ago

fedeghe commented 8 years ago

Hello, first of all thank You for the great work!!! Dean you are one of my heroes!!! But I'm not here for adulation: starting from the same code the node version has a different result then the one obtained in http://dean.edwards.name/packer/ ( Base62 encoded, no Shrink variables ) the first breaks, the second run smooth as expected I use the node version on a builder I wrote, it would be great if the node port could be as reliable as the online version. Many Thanks

evanw commented 8 years ago

My name is not Dean, sorry. This was a port I did a long time ago and the community has moved on since then. Now most people use uglify. I was keeping this port up in case people are depending on it, but it's not intended for use with new projects. I would recommend using uglify instead because it's a large community effort and is more durable than packer.

If you're still interested in using this library, I can try to fix it. It'll be easier to make sure it's fixed if you give me an example of code that is currently broken.

fedeghe commented 8 years ago

Then sorry Evan,

No, I think I will definitely follow you advice and migrate to uglifyjs once for all.

Thanks

Il 6/6/16 15:42, Evan Wallace ha scritto:

My name is not Dean, sorry. This was a port I did a long time ago and the community has moved on since then. Now most people use uglify https://github.com/mishoo/UglifyJS2. I was keeping this port up in case people are depending on it, but it's not intended for use with new projects. I would recommend using uglify instead because it's a large community effort and is more durable than packer.

If you're still interested in using this library, I can try to fix it. It'll be easier to make sure it's fixed if you give me an example of code that is currently broken.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/evanw/packer/issues/6#issuecomment-223962237, or mute the thread https://github.com/notifications/unsubscribe/ABRUcioO3i6vgnn_2XugKN0efyPKYu41ks5qJCO7gaJpZM4IsXj7.

czmirek commented 7 years ago

Sure, uglify has a strong support...

But:

That's one third file size reduction and the code still works. One third is significant enough for me to post this message and give this some support.

And the only thing for this little project to work is to update the jsdom to new version which does not depend on contextify which does not work for node js 7 :)