evargast / signature-generator

https://evargast.github.io/signature-generator/
MIT License
2 stars 1 forks source link

feat: added the email field regex check for an email format string #68

Closed ramirezStefano closed 1 year ago

ramirezStefano commented 1 year ago

re #61

ramirezStefano commented 1 year ago

👾

ramirezStefano commented 1 year ago

morpheus

ramirezStefano commented 1 year ago

Hello hello! Just pushed the last implementation as to handle the use effect only when the text value changes in the email field. Cheers! 🍻

ramirezStefano commented 1 year ago

Hello hello the handleInputChange handler has been updated with similar logic used within the useEffect 🚀

ramirezStefano commented 1 year ago

Hello hello has been dealing with a nasty bug regarding a previous state that needed to updated during the current render, tired to not use useEffect but at the end and lots of tries seemed to at least give the desired UX experience, lmk about the use of useEffect and if there was better way to update the state, tried a couple from the React docs but to no success 😢

ramirezStefano commented 1 year ago

Hello hello the latest implementation has been reviewed and merge conflicts have been resolved, tried to test but local machine required installing the route package, beyond that looks good! lmk if testing extends to downloading the missing local dependencies!

ramirezStefano commented 1 year ago

morpheus

Code cleaned up and tested, looking good!