evazion / translate-pixiv-tags

MIT License
35 stars 6 forks source link

Moved remaining global execution functions to main #30

Closed BrokenEagle closed 5 years ago

BrokenEagle commented 5 years ago

This one was missed when doing pull #27. I also commented the end to explicitly state where program execution starts.

7nik commented 5 years ago

Here is a problem: viewport and container in the ARTIST_QTIP_SETTINGS will have incorrect value. For container it isn't critical, it just resets to body. But for viewport it is, now the tooltips are always located below the tag even if there no enough space.

I see three ways to fix it:

BrokenEagle commented 5 years ago

I didn't see that dependency. Good catch!

For myself, I'd either add it in the initialize function, or extrapolate that whole thing into it's own function which I did with the follow-on commit.