evazion / translate-pixiv-tags

MIT License
35 stars 6 forks source link

Provide additional methods/info to exit settings menu #32

Closed BrokenEagle closed 5 years ago

BrokenEagle commented 5 years ago

To myself at least, it wasn't clear. I was looking for a cancel button, and also tried the escape key, both of which I'm used to from the jQuery dialog box as seen on Danbooru.

Some suggestions:

7nik commented 5 years ago

I'm not glad to add library/plugin only for solving a quite trivial case.

BrokenEagle commented 5 years ago

Yeah, that's fine. It looks a bit cleaner, but I can also understand not wanting to add another library. As for myself and Danbooru, we use it a lot more often in our code so it makes sense to have it.