Fix invalid URLS being queried

evazion / translate-pixiv-tags

MIT License

35 stars 6 forks source link

Fix invalid URLS being queried #55

Closed BrokenEagle closed 1 year ago

BrokenEagle commented 3 years ago

The find by artist URL sometimes triggers on URLs that shouldn't be queried. This was noticed first on Twitter with the trend URLs with the "/search" and URL parameter "src=trend_click". This doesn't harm anything, but it consumes resources needlessly on the client and server.

7nik commented 3 years ago

I tried to click the trend tags but noticed nothing about /search artist miss in the console. Maybe it'd better adjust the rule that is triggered.

BrokenEagle commented 3 years ago

It's not by clicking the trend link itself. It was seen in either an artists main timeline, their media timeline, or their likes timeline.

7nik commented 3 years ago

Oh, sorry, for some reason, I missed your reply. After an hour of scrolling, I found a few minor issues but not this one. Looks like it triggered by links in the trends sidebar, but I don't have there any \<a>.