Closed bartashevich closed 2 days ago
@bartashevich thank you for this PR. Unfortunately, we can't implement it this way: your PR largely duplicates the code that we already have in the fixed tariff. Instead, we need to reuse as much as possible, much more if we want to add this to other tariffs.
Also: your example of adding prices for zones is confusing. The price already comes from ENTSO-E, so why would you want to manually define it?
@bartashevich thank you for this PR. Unfortunately, we can't implement it this way: your PR largely duplicates the code that we already have in the fixed tariff. Instead, we need to reuse as much as possible, much more if we want to add this to other tariffs.
Also: your example of adding prices for zones is confusing. The price already comes from ENTSO-E, so why would you want to manually define it?
Fixed zone pricing seems a bit more complex and not easy to adapt for dynamic pricing.
In terms of ENTSO-E, price come in raw and we have a lot of custom taxes to apply. And on top of that, we need to apply zoned pricing.
I wasn't expecting for this PR to be merged right away. I'm happy to keep on working on this until we reach ideal solution.
In terms of ENTSO-E, price come in raw and we have a lot of custom taxes to apply. And on top of that, we need to apply zoned pricing.
It still seems your example is not using the Entso price add all?
Also note https://github.com/evcc-io/evcc/pull/17414 which could be used instead of zones?
Also note #17414 which could be used instead of zones?
Can you provide me an example where I can apply both:
@andig, What about reusing code from fixed zones by implementing sum of 2 tariffs?
If dynamic tariff have zones, it would create fixed tariff entity and then it would sum to current dynamic tariff.
Do you think that would work?
Can you provide me an example where I can apply both:
How about, instead of adding zones:
charges := 0.0860
if hr := ts.Hour(); hr < 8 || hr >= 23 {
charges = 0.0157
}
(price + 0.004 + 0.0028930 + 0.010) * 1.16 + 0.005 + charges
/cc @VolkerK62 @naltatis bzgl. Doku
dismissed in favor of https://github.com/evcc-io/evcc/pull/17414
Fix https://github.com/evcc-io/evcc/issues/12371
Example for BZN|PT domain with feedin and grid:
Same code can be added to other tariffs. Once it reaches final version.