Make add_with_opts throw error on invalid options.

evdb / HTTP-Async

process multiple HTTP requests in parallel without blocking

http://search.cpan.org/dist/HTTP-Async/lib/HTTP/Async.pm

8 stars 14 forks source link

Make add_with_opts throw error on invalid options. #11

Closed tgt closed 9 years ago

tgt commented 9 years ago

The new method throws an error when it receives an invalid option, but the add_with_opts method did not. This caught me out when I accidentally passed proxy_address and proxy_port rather than proxy_host and proxy_port to it. This resulted in it attempting to treat the host of my request as the proxy and hanging until the request timed out.

kaoru commented 9 years ago

Awesome, thanks for the patch :-) I'll merge it when the Travis CI build finishes successfully.

kaoru commented 9 years ago

HTTP::Async 0.29 with your patch included is flying off to CPAN!