Update lib/HTTP/Async.pm

evdb / HTTP-Async

process multiple HTTP requests in parallel without blocking

http://search.cpan.org/dist/HTTP-Async/lib/HTTP/Async.pm

8 stars 14 forks source link

Update lib/HTTP/Async.pm #5

Closed c00ler- closed 11 years ago

c00ler- commented 11 years ago

Added "LocalAddr" and "LocalPort" options for making http connection

kaoru commented 11 years ago

This was failing on travis-ci but it was a bug in travis not in the code in the pull request. I restarted the travis-ci build and it succeeded :-)

Will take a look at this more closely later and consider merging the pull request.

Thanks,

- Alex

kaoru commented 11 years ago

Fixed in 75469fa8ee71250cb6a5e77d1957718f17c93916. Note that to match the existing proxy_host and proxy_port options I changed the names to local_addr and local_port. Also added a test, which doesn't completely test the behaviour but I verified it by hand using lsof :-P (see https://github.com/evdb/HTTP-Async/blob/master/t/local-addr.t#L32)