evdubs / Harmonia

Margin funding bot for Bitfinex
20 stars 8 forks source link

Bug with BTC getting into calculations, Need to check "USD" #3

Open Scottiiee opened 9 years ago

Scottiiee commented 9 years ago

1) Need to be checking "USD" in activeOffers & activeCredits or BTCs/LTCs will be calculated in.

2) inactiveFunds is compared to $50, but Bitfinex has a $100 minimum on lending. Should this be changed to $100?

I made the fixs and can submit a pull request.

I was going to start implementing BTC/LTC swaps as well.

I have an idea about using Autorenew for the swaps. That way the minimum is $10 instead of $100. I can try to work on that also.

evdubs commented 9 years ago
  1. Sounds great!
  2. I commented on your pull request. Have you tried submitting a swap offer between $50 and $100? I have been able to submit them with success.

Go ahead with BTC/LTC swaps.

What is your idea about autorenew? When I last checked, I did not see a RESTful interface to enable autorenew. When I had used autorenew before building Harmonia, I could send arbitrary amounts (less than $1).

Scottiiee commented 9 years ago

Yep, there is no API access to autorenew. On the support page it states that the min for autorenew is $10, but I think that interest will autorenew.

evdubs commented 9 years ago

So how do you propose controlling the interest rate used by auto renew?

Scottiiee commented 9 years ago

I thought that there was API access. I now wonder if you could do something along the lines to set the autorenew manually and update the code where it cancels the offer to only cancel if the offer is < 50.