Closed hoank101 closed 6 months ago
The updates involve significant changes to a blockchain setup script and the genesis configuration of the "local-eve" network. The script adjustments boost genesis account balances, extend the voting period, and tweak various fees and parameters. The new genesis.json
sets up initial state configurations for multiple blockchain modules, establishing a robust foundation for network operations.
File Path | Change Summary |
---|---|
scripts/run-node.sh |
Increased genesis account balances by 1000x, extended voting period to 600s, adjusted minting and fee parameters. |
testnets/genesis.json |
Introduced initial state for "local-eve" network with configurations for various modules and initial balances. |
🌟🐇 A Poem by CodeRabbit 🐇🌟
In the realm of code and byte,
Changes dance through day and night.
Balances grow, and times extend,
A new genesis, a fresh amend.
Hop and thump, the network's set,
In blockchain's weave, the threads we've met.
scripts/run-node.sh (5)
[warning] 22-22: Use var=$(command) to assign output (or quote to assign string). --- [info] 65-65: Double quote to prevent globbing and word splitting. --- [info] 66-66: Double quote to prevent globbing and word splitting. --- [info] 67-67: Double quote to prevent globbing and word splitting. --- [info] 68-68: Double quote to prevent globbing and word splitting.
devskim success (1)
testnets/genesis.json: [notice] 315-315: Accessing localhost could indicate debug code, or could hinder scaling. Do not leave debug code in production
scripts/run-node.sh (3)
`60-62`: LGTM! The increased genesis account balances align with the PR's objectives for enhanced testing capabilities. --- `64-64`: Consider quoting the variables in the `update_test_genesis` function calls to prevent globbing and word splitting issues. ```diff - update_test_genesis '.app_state["gov"]["voting_params"]["voting_period"]="600s"' + update_test_genesis ".app_state['gov']['voting_params']['voting_period']='600s'" ``` --- `64-64`: The modifications to enable the REST server and adjust its settings are appropriate for enhancing accessibility and testing.testnets/genesis.json (1)
`1-474`: The `genesis.json` file is well-structured and aligns with the objectives of setting up a robust test environment for the "local-eve" blockchain network.
Summary by CodeRabbit