Closed tuantran1702 closed 4 months ago
The changes introduce a feemarket
module to the application, enhancing fee handling and transaction processing. New structures, handlers, and initializations related to the fee market are included. Additionally, new test cases, error definitions, and upgrade mechanisms are provided to support this module. This lays the groundwork for improved fee resolution and processing capabilities within the app.
File(s) | Change Summary |
---|---|
app/ante.go | Added feemarket imports, setup FeeMarketKeeper and AccountKeeper in HandlerOptions , introduced DenomResolverImpl , and updated ante handler construction. |
app/app.go | Updated imports, modified maccPerms , added FeeMarketKeeper , included feemarket module in several functions, and updated posthandler setup. |
app/upgrades.go | Removed //nolint:staticcheck directive and included FeeMarketKeeper in AppKeepers , added v1 upgrade. |
app/ante/ante_test.go | Added tests for fee handling logic, verifying different fee amounts and denomination scenarios. |
app/ante/errors.go | Introduced error definitions and functions for Ante module, focusing on missing keepers and configurations. |
app/upgrades/v1/constants.go | Added constant Upgrade with details and listed modules for upgrades in StoreUpgrades . |
app/upgrades/v1/upgrades.go | Added functions to create upgrade handlers and configure the fee market module. |
sequenceDiagram
participant User
participant AnteHandler
participant FeeMarketKeeper
participant DenomResolver
User->>AnteHandler: Submit Transaction
AnteHandler->>FeeMarketKeeper: Validate Transaction Fee
FeeMarketKeeper->>DenomResolver: Resolve Denomination
DenomResolver-->>FeeMarketKeeper: Return Resolution
FeeMarketKeeper-->>AnteHandler: Validation Result
AnteHandler-->>User: Transaction Status
Amidst the code, a market rises bright,
Where fees grow fair and rightly paid in light,
With handlers deft and resolvers keen,
Transactions flow as smooth as a dream.
Upgrades now in place, the future's clear,
In the realm of fees, there's naught to fear. 🎉
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@coderabbitai review
In upgrades.go, there are a number of deprecated calls. Are these needed?
I'd like to get this PR landed asap if possible.
Description
Partially addresses #245
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Upgrades