eve-network / eve

Eve is a governance minimized CosmWasm chain
Other
44 stars 32 forks source link

feat: integrate x/feemarket #250

Closed tuantran1702 closed 4 months ago

tuantran1702 commented 4 months ago

Description

Partially addresses #245

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The changes introduce a feemarket module to the application, enhancing fee handling and transaction processing. New structures, handlers, and initializations related to the fee market are included. Additionally, new test cases, error definitions, and upgrade mechanisms are provided to support this module. This lays the groundwork for improved fee resolution and processing capabilities within the app.

Changes

File(s) Change Summary
app/ante.go Added feemarket imports, setup FeeMarketKeeper and AccountKeeper in HandlerOptions, introduced DenomResolverImpl, and updated ante handler construction.
app/app.go Updated imports, modified maccPerms, added FeeMarketKeeper, included feemarket module in several functions, and updated posthandler setup.
app/upgrades.go Removed //nolint:staticcheck directive and included FeeMarketKeeper in AppKeepers, added v1 upgrade.
app/ante/ante_test.go Added tests for fee handling logic, verifying different fee amounts and denomination scenarios.
app/ante/errors.go Introduced error definitions and functions for Ante module, focusing on missing keepers and configurations.
app/upgrades/v1/constants.go Added constant Upgrade with details and listed modules for upgrades in StoreUpgrades.
app/upgrades/v1/upgrades.go Added functions to create upgrade handlers and configure the fee market module.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AnteHandler
    participant FeeMarketKeeper
    participant DenomResolver

    User->>AnteHandler: Submit Transaction
    AnteHandler->>FeeMarketKeeper: Validate Transaction Fee
    FeeMarketKeeper->>DenomResolver: Resolve Denomination
    DenomResolver-->>FeeMarketKeeper: Return Resolution
    FeeMarketKeeper-->>AnteHandler: Validation Result
    AnteHandler-->>User: Transaction Status

Poem

Amidst the code, a market rises bright,
Where fees grow fair and rightly paid in light,
With handlers deft and resolvers keen,
Transactions flow as smooth as a dream.
Upgrades now in place, the future's clear,
In the realm of fees, there's naught to fear. 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
faddat commented 4 months ago

@coderabbitai review

coderabbitai[bot] commented 4 months ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
faddat commented 4 months ago

In upgrades.go, there are a number of deprecated calls. Are these needed?

I'd like to get this PR landed asap if possible.

coderabbitai[bot] commented 4 months ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
coderabbitai[bot] commented 4 months ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.