Closed tnv1 closed 4 months ago
[!WARNING]
Review failed
The pull request is closed.
The update in the app/app.go
file introduces a critical functionality enhancement to the NewEveApp
function by adding the method call app.ICAHostKeeper.WithQueryRouter(app.GRPCQueryRouter())
. This ensures that the query router in the Interchain Account (ICA) Host Keeper is properly initialized, addressing the issue where the query router was previously nil.
Files | Change Summary |
---|---|
app/app.go |
Added app.ICAHostKeeper.WithQueryRouter(app.GRPCQueryRouter()) to NewEveApp |
Objective | Addressed | Explanation |
---|---|---|
Query router must not be nil (#258) | ✅ |
In the code where routers lie, An error once that made us sigh. But now a rabbit hopped to fix, With query routing in the mix. So, code flows smooth and worries fly! 🐰💻
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
thank @tnv1 <3
Closes #258
Summary by CodeRabbit