evedaktyl / pe

0 stars 0 forks source link

Sequence Diagram for the execute("delete 1") API Call is not Fully Accurate #13

Open evedaktyl opened 5 months ago

evedaktyl commented 5 months ago

image.png From above, the arguments passed to DeleteCommandParser include a whitespace in front. Hence it would be more accurate to use parse(" 1") in the sequential diagram, instead of parse("1") as seen below. image.png

nus-pe-script commented 5 months ago

Team's Response

We think this is a typo.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: image.png

The above section says that if the credibility of the diagram is affected, the bug can be of Low severity or higher.

It is also not a typo since all the sequence diagrams have the same issue.