evedaktyl / pe

0 stars 0 forks source link

Inconsistent Phrasing for Activity Diagram #15

Open evedaktyl opened 5 months ago

evedaktyl commented 5 months ago

image.png

In the above screenshot, the phrasing for the branch conditions can be more consistent. E.g. change to 'policy index is provided' and 'policy value is blank'.

soc-se-bot commented 5 months ago

Team's Response

image.png

According to the course website, we label grammar errors (which we think is the closest here) as NotInScope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This is an issue that hinders the reader. [is policy index provided] is not a condition, and having an [else] does not make sense.

If phrased as [policy index is provided], then it is clear that [else] is equivalent to [policy index is not provided].