evedaktyl / pe

0 stars 0 forks source link

Policy Command Allows Invalid Premium Value #7

Open evedaktyl opened 2 months ago

evedaktyl commented 2 months ago


video:https://raw.githubusercontent.com/evedaktyl/pe/main/files/12d51573-3ea1-4826-a0d2-72bd366ca437.mov

As seen in the above screen recording, the UG specifies that for a policy, the premium must have a value more than 0. However, it is possible to add a policy with premium 0.

nus-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Premium can be 0 when policy is created but will show as " - "

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


Screenshot 2024-04-19 at 5.22.33 PM.png

Perhaps, the positive value of premium would be a better term.


[original: nus-cs2103-AY2324S2/pe-interim#4488] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/evedaktyl/pe/main/files/fb6a5d08-082c-4bfd-9478-f517c8e5471e.png) Considering the above section, it may seem that the mismatch between the application behaviour and the UG can be fixed simply by updating the constraints on the premium value in the UG to be >= 0 instead of > 0. However, the application will still show a '-' for the a premium value of 0 instead of '0', which is unlikely to be the intended behaviour (if the value '0' is accepted like every other positive integer but is displayed differently).
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/evedaktyl/pe/main/files/c317a6f5-58f6-47fc-ac1d-2e52f9982029.png) An inaccurate constraint specified in the user guide is not purely a cosmetic bug.