search

evemondevteam / evemon

A lightweight, easy-to-use standalone Windows application designed to assist you in keeping track of your EVE Online character progression.
183 stars 169 forks source link

Evemon crashing on citadel contracts #38

Open privatemeta opened 7 years ago

privatemeta commented 7 years ago

When creating, changing, deleting or accepting a contract that is based in citadels, evemon crashes. The bug happens when hovering over the magnifying glass or x on the citadel contract notification.

See bug report here https://forums.eveonline.com/default.aspx?g=posts&m=6600926#post6600926

elliena-bulmer commented 7 years ago

@privatemeta I'll try to have a look at the issue and have a fix before the next version released.

privatemeta commented 7 years ago

Apparently this also happens when selling stuff on citadel markets (and market change notifications come in)

adi-tetac commented 7 years ago

I keep getting this more with the market since I have more market orders than contracts, here are links to the functions the errors point to that I think the issue is with. Market function from errors https://github.com/evemondevteam/evemon/blob/master/src/EVEMon/Controls/NotificationList.cs#L622 line I suspect .AppendLine(order.Station.Name); https://github.com/evemondevteam/evemon/blob/master/src/EVEMon/Controls/NotificationList.cs#L650 Contract function from errors https://github.com/evemondevteam/evemon/blob/master/src/EVEMon/Controls/NotificationList.cs#L661 line I suspect .AppendLine(contract.StartStation.Name); https://github.com/evemondevteam/evemon/blob/master/src/EVEMon/Controls/NotificationList.cs#L690

Its been a few years since I've touched C# but would changing .AppendLine(contract.StartStation.Name); to .AppendLine(contract.StartStation.Name ?? "Citadel"); or something similar work? or am I misremembering how it works/misidentifying the issue?