search

evenchange4 / react-grecaptcha

React.js Google reCAPTCHA v2 integration component.
https://react-grecaptcha.netlify.com
MIT License
51 stars 8 forks source link

omit invalid HTML props from the rendered div tag that have been pass… #35

Closed fde31 closed 7 years ago

fde31 commented 7 years ago

…ed the component's props until now

fixes #34

fde31 commented 7 years ago

seems to be related to linting issues. However the linting setup seems a bit messed up or am I missing something?! I switched from Node v6.6.0 to Node v4.3.1 in order to get the peerDeps right (maybe worth updating the repo for that, too!?) but still no luck. Punting on this for now as I assume that it might be quicker and easier for u to resolve that!? Otherwise I'm happy to help. Just lemme know.

evenchange4 commented 7 years ago

For eslint dependency error please try to install npm@2, and I create another issue #36 for this problem.

Please rebase onto master branch, and you can use node v6 and npm v3 now!

fde31 commented 7 years ago

ah sure. we could do that. didn't think about the propTypes removal. so I guess hardcoding the props might be the way to go. will take care

codecov-io commented 7 years ago

Current coverage is 37.50% (diff: 100%)

Merging #35 into master will increase coverage by 2.71%

@@             master        #35   diff @@
==========================================
  Files             1          1          
  Lines            23         24     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits              8          9     +1   
  Misses           15         15          
  Partials          0          0

Powered by Codecov. Last update 31c0766...ac1d729

evenchange4 commented 7 years ago

Thanks! Released v1.1.1 with your changes.