Closed zmoshansky closed 10 years ago
@zmoshansky .. thanks, happy it's helping!
Ahah, you mean in generate_signature
where it does this?
params.except(:action, :controller).keys.sort.each ...
Yes, definitely a good fix.
yes, exactly :+1:
Would the correct way to do this be to use request.request_parameters
instead? It should give you the raw POST data, unlike params
which is the hash after some parsing, etc. has occurred.
If so, I can whip up a quick pull request.
Same problem here, with a subdomain
param added in my routes file. I definitely second the suggestion to use request.request_parameters
.
:beer: everyone - I pulled @gspiers fix into the 1.0.2 release
I want to lead with thanks for this Gem!
I noticed while working on a project that the Webhook Processor fails to generate the correct signature if there are additional controller params. This was caused by a default 'format' tag inherited in my routes file (<-Totally my bad, but not easy to track down). Is it worthwhile to add format to { 'actions', 'controller' } to avoid this issue or simply whitelist the known good params from mandrill?