search

evendis / mandrill-rails

Webhook processing and event decoration to make using Mandrill with Rails just that much easier
MIT License
288 stars 36 forks source link

Why do you need `mandrill` as a runtime dependency? #2

Closed ssaunier closed 11 years ago

ssaunier commented 11 years ago

Can't figure out from looking at the code, sorry...

tardate commented 11 years ago

I think you might be right - the mandrill gem isn't really required. I think I must have added it during early experiments but never removed when the need for it was no longer there.

Does it cause you any problems?

ssaunier commented 11 years ago

Hi @tardate,

The thing is, I was trying to figure my way through the 5 gems about Mandrill https://rubygems.org/search?utf8=%E2%9C%93&query=mandrill

Turns out tatemae-consultancy/mandrill works great (and this is the gem you require_dependency), but the guys are telling me that they migrated to use the mailchimp/mailchimp-gem (https://github.com/tatemae-consultancy/mandrill/pull/3#issuecomment-17086032) which makes sense.

The official mailchimp gem (embedding integration with the Mailchimp API) does not support Webhooks like yours greatly do, so the idea would be that your gem addresses only the webhooks (and advertise it more clearly by maybe renaming it to mailchimp-webhook), and just extend the module Mailchimp::Mandrill ?

Just my 2 cents.

Thanks !

tardate commented 11 years ago

That's a very good suggestion @ssaunier, and thanks for the update on the mailchimp gem status.

I think what I'll do for now is just drop the mailchimp gem requirement.

ssaunier commented 11 years ago

Sounds like a plan! Do you have an ETA for the 0.0.4? Do you need help? Thanks!

tardate commented 11 years ago

Thanks for the offer of help @ssaunier but it turned out to be a one-liner after all - didn't find any hidden complexities after making the change. I'll push a new gem version as soon as tests confirmed green