evendotnet / Even

An event sourcing framework on top of Akka.NET
134 stars 29 forks source link

Created an automated build script #5 #21

Closed DamianReeves closed 8 years ago

DamianReeves commented 8 years ago

This is a good start but there are a couple of tests which file sometimes when I run them outside of the script. They seem to fail all the time with the script.

What Works

DamianReeves commented 8 years ago

I can't seem to get some of the tests to pass when run either directly from the build script or run in AppVeyor.

I added xUnit trait to some tests:

nvivo commented 8 years ago

@DamianReeves

This is great! Let me just take a look at the tests and appveyour to see what happens with those tests.

Do you have more commits planned for this PR?

DamianReeves commented 8 years ago

No more commits planned. I'm embarrassed I ended up with so many before I realized that the tests failing was a known issue reported the day before.

Also concerning the usage of Paket here are my thoughts:

Thoughts?

nvivo commented 8 years ago

I agree. Let's get CI going, try paket and fix the tests later.

About the commits, it's a good practice to squash before submiting a PR. In TortoiseGit it's simple to rebase + squash all comits into one. Then you just force push your branch to github, it should reflect here.

DamianReeves commented 8 years ago

Closing this one as I have a squashed pull request as requested.