Codecov Report

Merging #35 into master will decrease coverage by 1.17%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage     100%   98.82%   -1.18%     
==========================================
  Files           2        2              
  Lines          87       85       -2     
==========================================
- Hits           87       84       -3     
- Misses          0        1       +1

Impacted Files	Coverage Δ
rest_framework_serializer_extensions/utils.py	`97.72% <100%> (-2.28%)`	:arrow_down:
rest_framework_serializer_extensions/fields.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7a43cd...5ff02d5. Read the comment docs.

evenicoulddoit commented 4 years ago

Looks great from first inspection, thanks! I'm not sure how this drops code coverage :thinking:. I was also confused as there's no report of a Travis build, but on closer inspection, it appears to actually be pre-emptively merging with master and running a build on that, which is neat, but there's just no feedback!

Post merging this, I'd suggest that I should bump the package to 2.0.0 as dropping Py2 seems cause for a major release?

Hope to get some more time to look at this later and merge :+1:

ChrisBurch commented 4 years ago

Sounds good regarding 2.0.0 ! Thanks for taking a look. Yeah I was curious about the coverage drop, too, unsure how that came to be

evenicoulddoit commented 4 years ago

Sweet, thanks!

evenicoulddoit / django-rest-framework-serializer-extensions

Adding Django 3.0 support #35

Codecov Report