Update CI to test against current Python/Django/DRF

evenicoulddoit / django-rest-framework-serializer-extensions

Extensions to help DRY up Django Rest Framework serializers

Other

247 stars 23 forks source link

Update CI to test against current Python/Django/DRF #56

Closed philipstarkey closed 8 months ago

philipstarkey commented 8 months ago

With the release of DRF 3.15, bringing official support for Django 4.2+, I thought it would be a good opportunity to update the CI config of this project to test against support versions of Python/Django/DRF and drop official support for versions of those dependencies that are no longer getting updates.

Changes

Updated CI to run on currently supported Python versions (3.8+)
Drop support for unsupported Python versions
Updated CI to test against currently supported Django (3.2, 4.2, 5.0) and Django Rest Framework versions.
Drop support for unsupported Django versions
Updated CI dependencies to latest versions (required for Python 3.12 support)
Updated dev dependencies to latest versions (required for Python 3.12 support)
Updated documentation to reflect the requirements changes
Updated PyPI metadata to reflect updated requirements
Fix bug where black return status wasn't causing CI to fail
Minor formatting changes due to upgrade of black version
Update of re_path import in test
Bumped version to 3.0.0 (major release due to dropping support for older versions)

evenicoulddoit commented 8 months ago

Hi @philipstarkey , thanks so much for this. Changes look great. I'm guessing the stylistic ones are just to keep Black happy. I'm using Ruff professionally now, it occurs to me that I could upgrade to this, plus go the pyproject.toml route

philipstarkey commented 8 months ago

I'm guessing the stylistic ones are just to keep Black happy. I'm using Ruff professionally now, it occurs to me that I could upgrade to this, plus go the pyproject.toml route

Yes! The stylistic change were to keep black happy. I'm not sure if that was due to the black version change, or just because black wasn't being passed --check so was never raising an exit code that would cause tox to fail. I'm also using Ruff professionally now - it does seem like it's the future.

Also, are you able to update the CHANGELOG? I couldn't remember, but I think I've been handling version updates manually, but always as part of a separate commit. So, I think we should remove the __version__ being changed here :)

I have updated the change log and reverted __version__. Let me know if there is anything else I can do!