evennia / ainneve

A full example game created in Evennia (under development, anyone can help!)
77 stars 52 forks source link

Merge Develop branch into Master #107

Closed aliceafterall closed 6 years ago

aliceafterall commented 6 years ago

It's finally ready! The develop branch runs with no problems, all the code we needed to change is changed, and all our tests work and pass. Please read below for a summary, or take a look at the development server.

Summary

Quirks

So far, we've tested this out fairly well. There's a development server up if anyone wants to take a look. There are some bugs that Ainneve itself still has, but all the kinks related to the move to 0.7 have been fixed, as far as I've been able to find myself, and others have found.

There's an oddity with combat, where we're not clear about the fact that one needs to equip their weapon to use it, though I think that's in master as well.

The future

feend78 commented 6 years ago

One other note about the EvMenu unit tests. They are not designed to test whether the menu is rendering correctly. Rather, they are testing that the @ic or @charcreate commands called on a partially-created character resumes the menu at the correct node. I will agree that they have always been fragile (and therefore frustrating to work with). Just keep in mind that purpose if you plan to re-work them.

aliceafterall commented 6 years ago

Excellent point - I forget things like this. @Griatch built a framework for testing EvMenu as well, if there is a rework with them it'd use that framework.

Edit: Just to clear up those odd PROTOTYPE_SETTINGS changes there, there's an odd bug in Evennia core itself, it seems. Without those, the tests will fail when they spawn items.

aliceafterall commented 6 years ago

Consider it done! We'll get rid of our little PROTOTYPE_MODULES hack once Evennia core fixes that.