Closed Laupetin closed 3 months ago
Latest commit: 87e4ea085871e2a9fcd3c3b9857d2f6028f56b0d
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Nice find, thank you @Laupetin 🙏
@all-contributors add @Laupetin for code
@boyney123
@Laupetin already contributed before to code
Motivation
When using the default base url configuration it defaults to
/
. The favicon url is currently evaluated fromwhich results in a url of
//favicon.ico
.The browser interprets that as a host and tries to load a favicon from
https://favicon.ico/
(if the catalog url uses https as protocol).This PR makes the favicon url use the utils method that other places use as well to calculate its url.