search

event-catalog / eventcatalog

An open source documentation tool to bring discoverability to your event-driven architectures
https://eventcatalog.dev
MIT License
1.67k stars 139 forks source link

fix: cleanUrl must only replace double slash in URL pathname #688

Open c-wygoda opened 1 month ago

c-wygoda commented 1 month ago

Motivation

URLs in anchors in HTML are invalid as cleanUrl also replaces the double slash in the schema part instead of only in the pathname, which causes links to be broken.

Have you read the Contributing Guidelines on pull requests?

No, because that file does not exist.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 9dae0aaabd0763e8f416be1d8f8d0aa7bc1d7ca5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

boyney123 commented 1 month ago

Thanks @c-wygoda

boyney123 commented 1 month ago

@all-contributors add @c-wygoda for code

allcontributors[bot] commented 1 month ago

@boyney123

I've put up a pull request to add @c-wygoda! :tada:

boyney123 commented 1 month ago

We have a failing build on this at the moment, any chance you look @c-wygoda ?