search

event-centric / EventCentric.Core

Event Sourcing and CQRS in PHP
MIT License
126 stars 9 forks source link

lower dbal dep version to be able to use it in some stable projects #6

Closed cordoval closed 10 years ago

cordoval commented 10 years ago

may we please?

mathiasverraes commented 10 years ago

Breaks the build on HHVM. EventCentric is not ready for production anyway. If you can find an older version that works on HHVM, I'm fine with lowering the requirement.

cordoval commented 10 years ago

ok i will check this. Thanks!

henrikbjorn commented 10 years ago

Is the DBAL really needed or is it a require-dev dependency? Also maybe use stable releases for stuff like Assert.

mathiasverraes commented 10 years ago

DBAL is required. IIRC we depend on a bugfix in assert. When a new version is released, we can use that one.

henrikbjorn commented 10 years ago

@mathiasverraes wouldnt it be possible to use the event stuff in a small scale in memory ? Or just not use event sourcing at all ?

mathiasverraes commented 10 years ago

Currently no. That kind of setup will make more sense when I have messaging and projection infrastructure.

cordoval commented 10 years ago

I think doing it like a subtree split and adding composer.json's would allow that, but yeah is a bit of work. Let me know and i can help with those composer jsons @mathiasverraes that would be required. Also the dbal is only required for the mysql class 1 class, nothing else. The repo is overall pretty decoupled :+1:

cordoval commented 10 years ago

after tweaking deps in my project i feel this is not really necessary because everything resolves nicely.

composer.lock shows i am on master after a proper configuration

        {
            "name": "doctrine/orm",
            "version": "dev-master",