event-driven-dotnet / EventDriven.EventBus.Dapr

Event bus abstraction over Dapr pub/sub
MIT License
22 stars 5 forks source link

Suggestions around logging #3

Closed tonysneed closed 3 years ago

tonysneed commented 3 years ago

From @rynowak:

Here's some feedback based on my experiences supporting ASP.NET Core and Dapr for .NET. These are just my opinions so feel free to ignore my ideas if they are a bit fit for what you're trying to accomplish.

Logging

You should take advantage of named placeholders for logging rather than string formatting, as you are doing here.

using string formatting for logs is less performant and doesn't expose the info for key-value structured logging systems. using named placeholders works for both console loggers and key-value style loggers