event-driven-dotnet / EventDriven.EventBus.Dapr

Event bus abstraction over Dapr pub/sub
MIT License
22 stars 5 forks source link

Cloud Events Id #5

Closed tonysneed closed 3 years ago

tonysneed commented 3 years ago

From @rynowak:

Here's some feedback based on my experiences supporting ASP.NET Core and Dapr for .NET. These are just my opinions so feel free to ignore my ideas if they are a bit fit for what you're trying to accomplish.

Data from cloud event

I can see that you're making your own message ID and timestamp here. We should talk more about exposing this info from the cloud event payload. example

Currently UseCloudEvents doesn't expose this info, but we could talk about adding it for a 1.2 release. This way you could get the authoritative info from the server.

You might think about typing your Id as a string, there's no rule that says it has to be a guid (in cloud events). You could still use a guid to generate it, but this way you aren't locked to that data type.