search

event-driven-io / emmett

Emmett - a Node.js library taking your event-driven applications back to the future!
https://event-driven-io.github.io/emmett/
195 stars 19 forks source link

Added `node:test` as a dependency to `emmett` to prevent `MODULE_NOT_FOUND` errors #60

Closed alex-laycalvert closed 7 months ago

alex-laycalvert commented 7 months ago

Saved test as a dependency in the emmett package. Not sure if the files that use test were meant to be in the final build but this solved my issues locally after finding #59

alex-laycalvert commented 7 months ago

This might need to be a peer dep, I've never done any work on node libraries so not sure which is better.

oskardudycz commented 7 months ago

@alex-laycalvert, what you did is a valid solution, but I decided to tackle that issue a bit differently. More details in https://github.com/event-driven-io/emmett/pull/61.

Thank you a lot for providing good reproduce steps, a potential fix and patience. That's much appreciated. I'll go ahead and publish the 0.7.1 version with a fix now.