search

event-engine / docs

Event Engine Docs
https://event-engine.github.io
BSD 3-Clause "New" or "Revised" License
12 stars 5 forks source link

In-memory-database behaviour inconsistencies #9

Open sami0421 opened 3 years ago

sami0421 commented 3 years ago

Hey there :),

we really enjoy working with event-engine - thank you!

We recently encountered two inconsistencies compared to the postgres database:

  1. LikeFilter does not seem to be able to filter over nested, complex properties
  2. getDocs does return an ArrayIterator instead of a Generator

Versions:

"event-engine/discolight": "^0.2", "event-engine/php-data": "^1.0", "event-engine/php-document-store": "^0.6.0", "event-engine/php-engine": "^0.14", "event-engine/php-engine-utils": "^0.1", "event-engine/php-json-schema": "^1.0", "event-engine/php-logger": "^0.1", "event-engine/php-messaging": "^0.1", "event-engine/php-persistence": "^0.7", "event-engine/php-postgres-document-store": "^0.9.1", "event-engine/php-schema": "^0.1", "event-engine/prooph-v7-event-store": "^0.8",

Any help is appreciated :)!

Cheers

julia909 commented 3 years ago

Hi!

Additionally to the inconsistencies mentioned above, we encountered another inconsistency:

The in-memory-database converts simple string-wrapper objects in a filter value into actual strings. Therefore, if you forget to cast the filter value to string in the code, the in-memory-database still finds the queried data while the postgresql database does not.

We are happy for any feedback :) Cheers

codeliner commented 3 years ago

Hi @sami0421 and @julia909 , sorry for answering late. I somehow missed the issue. Too much github notifications recently ...

Can you provide failing test cases for mentioned inconsistencies? I think we can solve the differences together ;)