apkup -h returns a non-zero code: 1

eventOneHQ / apkup

🚀 Publish APKs to Google Play directly from the terminal

https://oss.eventone.page/apkup

MIT License

36 stars 12 forks source link

Closed sarn0ld closed 4 years ago

sarn0ld commented 4 years ago

Hey there!

Thank you for the good work!

I wanted to run apkup -h during my docker build on continous integration. But it returns 1 which indicates an error to CI and let the build fail...

I think --apk and --key should not be tested when running -h.

nprail commented 4 years ago

If you do apkup --help, it will return 0. -h isn't actually a valid flag so it returns 1.

It would probably make sense to add -h as an alias of --help, though, since that is pretty common 🙂

sarn0ld commented 4 years ago

Ah thank you... I just copied the -h from README.md...

Maybe just change the documentation? :-)

nprail commented 4 years ago

:tada: This issue has been resolved in version 1.3.1-beta.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

nprail commented 3 years ago

:tada: This issue has been resolved in version 1.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: