search

eventOneHQ / apkup

🚀 Publish APKs to Google Play directly from the terminal
https://oss.eventone.page/apkup
MIT License
36 stars 12 forks source link

Uploading deobfuscation fails #39

Closed sarn0ld closed 4 years ago

sarn0ld commented 4 years ago

After uploading a aab-file I get this error:

2020-10-01T12:36:07.632Z apkup:Upload > Uploading deobfuscation ERROR: request to https://www.googleapis.com/upload/androidpublisher/v3/applications/******/edits/1204090343508074****/apks/37/deobfuscationFiles/proguard?uploadType=media failed, reason: socket hang up

nprail commented 4 years ago

@sarn0ld Can you post the full command that you ran?

sarn0ld commented 4 years ago

Of course... here we go:

$ export DEBUG=apkup:*
$ apkup --track internal --release-notes "en-US=Automated Upload from Gitlab - PipelineID $CI_PIPELINE_ID" --apk app/build/outputs/bundle/release/app-release.aab --deobfuscation app/build/outputs/mappings/release/mapping.txt --key ${GOOGLE_KEY}
- Uploading APK...
2020-10-01T12:35:53.603Z apkup:helpers > Parsing manifest
2020-10-01T12:35:53.603Z apkup:helpers > File path /builds/*********/app/build/outputs/bundle/release/app-release.aab
2020-10-01T12:35:53.874Z apkup:helpers > Detected package name *******
2020-10-01T12:35:53.874Z apkup:helpers > Detected version code 37
2020-10-01T12:35:53.875Z apkup:Edit > Authenticating
2020-10-01T12:35:54.050Z apkup:Edit > Authenticated successfully
2020-10-01T12:35:54.050Z apkup:Edit > Creating edit
2020-10-01T12:35:55.035Z apkup:Edit > Created edit with id 1204090343508074****
2020-10-01T12:35:55.035Z apkup:Upload > Uploading release
2020-10-01T12:36:06.441Z apkup:Upload > Uploaded app/build/outputs/bundle/release/app-release.aab with version code 37 and SHA1 6782d2e5ea7602dde5ee30d******
2020-10-01T12:36:06.441Z apkup:Upload > Assigning APK to internal track
2020-10-01T12:36:07.632Z apkup:Upload > Assigned APK to internal track
2020-10-01T12:36:07.632Z apkup:Upload > Uploading deobfuscation
ERROR: request to https://www.googleapis.com/upload/androidpublisher/v3/applications/*****/edits/1204090343508074****/apks/37/deobfuscationFiles/proguard?uploadType=media failed, reason: socket hang up
nprail commented 4 years ago

Hmm, based on the socket hang up error, sounds like it may be an issue with Google's servers. Have you tried re-uploading? Has uploading deobfuscation files worked for you before?

sarn0ld commented 4 years ago

I tried rerunning the job several times and it ended in the same error message. I haven't tried uploading the mapping.txt file before this project.

However, I now removed the --deobfuscation parameter and the upload works.

nprail commented 4 years ago

Okay. Are your mappings ProGuard mappings?

sarn0ld commented 4 years ago

Yes, it's the usual mappings.txt from R8. It's not the c symbols for native code debugging....

sarn0ld commented 4 years ago

@Vacxe Maybe you can share the command you use for uploading the deobfuscation file?

nprail commented 4 years ago

This is the code where the mappings upload occurs. https://github.com/eventOneHQ/apkup/blob/master/src/actions/Upload.ts#L113

Looks like you are getting the same error message as in r0adkll/upload-google-play#1 (which uses the same API). Based on that, it seems that the API responds with that error when the file doesn't exist. Is that potentially the issue? Can you double-check that the mapping file is where apkup expects it to be?

sarn0ld commented 4 years ago

🙈 Wow! Thank you very much! You are right!

app/build/outputs/mappings/release/mapping.txt ist wrong. app/build/outputs/mapping/release/mapping.txt would bei correct.

I have no access to the project right now and can only test it on monday. But I'm confident that it works when I change the path. So I'll close this issue now.

Thank you very much again! Keep up the good work! 👍

nprail commented 4 years ago

Awesome. In v2, I'll add some checks to make sure that specified files actually exist so that it can give you a reasonable error message :)