eventespresso / actions

Centralized repository for all of Event Espresso's GitHub Actions used in our CI/CD pipelines
GNU Affero General Public License v3.0
2 stars 6 forks source link

Update E2E Tests Repository Url #48

Closed alexkuc closed 11 months ago

alexkuc commented 11 months ago

As per title.

alexkuc commented 11 months ago

Code

private initFirefox(ctx: Context): void {

TSLint warning

'ctx' is defined but never used`

Once PR mentioned in the method will become merged, we will use variable ctx. Keep it as it is for now to avoid having to dig through the code to remember what parameter is.


Code

const [fileName, workDir, filePath] = this.getParams();

TSLint warning

'workDir' is assigned a value but never used

I can change workDir to undefined to avoid this warning. But the next person will need to dig the code to assign it to variable instead of just using workDir (if they will need workdir value).