search

eventespresso / barista

Javascript modules & tools for Event Espresso development
GNU General Public License v3.0
5 stars 1 forks source link

Fix optional property handling in DateCard component #1283

Closed tn3rb closed 8 months ago

tn3rb commented 8 months ago

This PR fixes #1282

alexkuc commented 8 months ago

Imho, this PR should not be merged until https://github.com/eventespresso/barista/issues/1281 is fixed because currently we have broken changes in master branch

Edit: please wait for PRs https://github.com/eventespresso/cafe/pull/978 and https://github.com/eventespresso/e2e-tests/pull/38 to be merged to resolve failing E2E tests

kingrio13 commented 8 months ago

Hmm, i'm not sure if im doing it right, but im having this problem. image

here's some problem in console. index.js:1 Missing field 'status' while writing result { "id": "VGlja2V0OjMy", "cacheId": "Ticket:32:658ba51ce7ca38.72710974", "dbId": 32, "description": "", "endDate": "2024-01-26T23:59:00+00:00", "isDefault": false, "isExpired": false, "isFree": true, "isOnSale": true, "isPending": true, "isRequired": false, "isSoldOut": false, "isTrashed": false, "max": -1, "min": 0, "name": "Free Ticket", "order": 0, "price": 0, "quantity": 100, "registrationCount": 0, "reserved": 0, "reverseCalculate": false, "sold": 0, "startDate": "2023-12-27T04:16:00+00:00", "userId": "dXNlcjox", "uses": -1, "visibility": "PUBLIC", "__typename": "EspressoTicket" }

alexkuc commented 8 months ago

@kingrio13 Because PR #1277 was already merged, your local Cafe repository needs to point to branch NEW/CORE/datetime-status otherwise there is no backend code to support new statuses