eventespresso / barista

Javascript modules & tools for Event Espresso development
GNU General Public License v3.0
5 stars 1 forks source link

Extract Feature Flag Details #1288

Closed tn3rb closed 7 months ago

tn3rb commented 7 months ago

Currently, Feature Flags (FFs) are defined in Core, but the FF admin is part of the Barista EE plugin. The FF form options were also defined in the Barista plugin. This is awkward because whenever a new FF is added, you need to add the FF to core as well as update the Barista plugin to add the new FF to the FF admin page form.

This PR:

So now, we only need to add new FFs to core, and the FF admin will just work without any further modifications

alexkuc commented 7 months ago

FYI, E2E fails due to this https://github.com/eventespresso/barista/issues/1281

Edit: to test PRs against E2E need to manually trigger them from Actions specifying the Cafe's branch as per the workaround above